Baseline new warning in trimming tests #114424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToolsTests legs are failing: #114406 (comment) Psychic debugging (without actually trying to repro anything) tells me this is from #114346 that makes us emit more dynamic keyword warnings. That PR didn't trigger the ToolsTests leg since it's not a ILLink change.
ghost
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/DynamicObjects.cs:132
- Consider adding a comment to clarify that the duplicate ExpectedWarning attribute is intentional, ensuring that future maintainers understand it reflects the new baseline for dynamic keyword warnings.
[ExpectedWarning ("IL3050", Tool.NativeAot, "https://github.com/dotnet/runtime/issues/94427")]
dotnet-policy-service
bot
added
the
linkable-framework
jkotas
added
the
area-Tools-ILLink
Contributor
|
Tagging subscribers to this area: @dotnet/illink |
am11
removed
the
needs-area-label
This was referenced Apr 9, 2025
Open
sbomer
approved these changes
Apr 9, 2025
Member
Author
|
/ba-g timeout in unrelated leg |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToolsTests legs are failing: #114406 (comment)
Psychic debugging (without actually trying to repro anything) tells me this is from #114346 that makes us emit more dynamic keyword warnings. That PR didn't trigger the ToolsTests leg since it's not a ILLink change.
Fix #114426