SVE: Slightly better calculation of stack frame for ldr/str#114284
Merged
kunalspathak merged 4 commits intodotnet:mainfrom Apr 9, 2025
Merged
SVE: Slightly better calculation of stack frame for ldr/str#114284kunalspathak merged 4 commits intodotnet:mainfrom
kunalspathak merged 4 commits intodotnet:mainfrom
Conversation
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/coreclr/jit/emitarm64.cpp:8334
- The associated comment indicates handling large immediates (> 9 bits), but the condition uses the threshold 4096. Consider aligning the comment with the code logic to avoid confusion.
if (imm < 4096)
Contributor
Author
|
/azp run Fuzzlyn, Antigen |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
Antigen and Fuzzlyn failures are unrelated. @dotnet/jit-contrib PTAL |
Contributor
Author
|
ping @dotnet/jit-contrib @dotnet/arm64-contrib |
jakobbotsch
reviewed
Apr 8, 2025
Contributor
Author
|
/ba-g failures are timeout related |
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.