Remove unused and unnecessary CLRConfigs.#114282
Merged
jkotas merged 3 commits intodotnet:mainfrom Apr 5, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (8)
src/coreclr/vm/i386/excepx86.cpp:829
- The removal of the debug-only assertion in the OOM handling path may reduce diagnostic feedback in debug builds; ensure that this change is intended and that alternative diagnostics are in place if needed.
#if defined(_DEBUG)
src/coreclr/vm/codeman.cpp:5146
- [nitpick] Consider renaming 'pwzJitNameMaybe' to a clearer name such as 'tempJitName' or 'jitNameTemp' to enhance code clarity.
LPWSTR pwzJitNameMaybe = NULL;
src/coreclr/vm/appdomain.cpp:922
- The removal of the debug pause loop controlled by 'INTERNAL_PauseOnLoad' should be verified to ensure that it does not impact developers who rely on this mechanism during debugging.
#ifdef _DEBUG
src/coreclr/md/compiler/regmeta.h:2059
- Removal of 'm_bKeepKnownCa' is appropriate for cleaning up unused configurations; please verify that no dependent logic assumes its presence.
bool m_bKeepKnownCa; // Should all known CA's be kept?
src/coreclr/md/compiler/regmeta.cpp:66
- The elimination of 'm_bKeepKnownCa' initialization aligns with the header changes; ensure that metadata attribute processing continues to function as expected.
m_bKeepKnownCa(false),
src/coreclr/md/compiler/custattr_emit.cpp:1027
- Updating attribute handling to use only 'props->bKeepCa' should be verified to ensure that removing 'm_bKeepKnownCa' does not alter the intended behavior for known custom attributes.
*bKeep = props->bKeepCa || m_bKeepKnownCa;
src/coreclr/inc/clrconfigvalues.h:111
- The removal of unused config values like 'INTERNAL_EnableFullDebug' should be cross-checked with all modules to ensure no inadvertent dependencies remain.
CONFIG_DWORD_INFO(INTERNAL_EnableFullDebug, W("EnableFullDebug"), 0, "Heavy-weight checking for AD boundary violations (AD leaks)")
src/coreclr/inc/clrconfigvalues.h:392
- Ensure that the coordinated removal of config values such as 'INTERNAL_MD_ForceNoColDesSharing' and 'INTERNAL_MD_KeepKnownCA' does not affect any legacy code paths or fallback behaviors.
RETAIL_CONFIG_DWORD_INFO(INTERNAL_MD_ForceNoColDesSharing, W("MD_ForceNoColDesSharing"), 0, "Don't know - the only usage I could find is #if 0 (?)")
Contributor
|
Tagging subscribers to this area: @mangod9 |
jkotas
reviewed
Apr 4, 2025
jkotas
reviewed
Apr 4, 2025
jkotas
reviewed
Apr 4, 2025
jkotas
reviewed
Apr 4, 2025
jkotas
reviewed
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.