Skip to content

Remove CreateFalse node during lowering, if MaskToVector is getting removed #114272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kunalspathak merged 5 commits into from
Apr 7, 2025
Merged

Remove CreateFalse node during lowering, if MaskToVector is getting removed #114272

kunalspathak merged 5 commits into from
Apr 7, 2025

Conversation

@kunalspathak
Copy link
Contributor

@kunalspathak kunalspathak commented Apr 4, 2025

During lowering, if we see CndSel(AllTrue, op2, op3), we replace it with op2 and delete AllTrue and op3. If op3 is AllFalse, we remove it too. However, it can be wrapped in MaskToVector(AllFalse) and in such case, we would just delete MaskToVector node and not AllFalse node. Fixed by removing that node as well.

Fixes: #113338

Copilot AI review requested due to automatic review settings April 4, 2025 17:29
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 4, 2025
Copilot AI reviewed Apr 4, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/tests/JIT/Regression/JitBlue/Runtime_113338/Runtime_113338.csproj: Language not supported

@kunalspathak
Copy link
Contributor Author

kunalspathak commented Apr 4, 2025

@dotnet/jit-contrib @dotnet/arm64-contrib

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Apr 4, 2025

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@kunalspathak kunalspathak mentioned this pull request Apr 4, 2025
Merged
@kunalspathak
Copy link
Contributor Author

kunalspathak commented Apr 4, 2025

most of the failures seems to be #113534 which is fixed in #114228. I will merge main, just to be sure.

@kunalspathak
Copy link
Contributor Author

kunalspathak commented Apr 4, 2025

/azp run Fuzzlyn, Antigen

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 4, 2025

Azure Pipelines successfully started running 2 pipeline(s).

jakobbotsch
jakobbotsch reviewed Apr 6, 2025
View reviewed changes
@kunalspathak
Copy link
Contributor Author

kunalspathak commented Apr 7, 2025

/azp run Fuzzlyn

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 7, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Apr 7, 2025
Open
@kunalspathak
Copy link
Contributor Author

kunalspathak commented Apr 7, 2025

osx/arm64 fuzzlyn failure is #113940

@kunalspathak kunalspathak merged commit 9559b2a into dotnet:main Apr 7, 2025
117 of 123 checks passed
@kunalspathak kunalspathak mentioned this pull request Apr 9, 2025
Closed
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@kunalspathak kunalspathak

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JIT: Assertion failed 'node->IsUnusedValue() && "found an unmarked unused value"' during 'Lowering nodeinfo'

2 participants

@kunalspathak @jakobbotsch