Fix the encoding for sve_mov#114244
Merged
kunalspathak merged 1 commit intodotnet:mainfrom Apr 4, 2025
Merged
Conversation
ghost
added
the
area-CodeGen-coreclr
Contributor
Author
|
@dotnet/jit-contrib @dotnet/arm64-contrib |
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/coreclr/jit/emitarm64sve.cpp:10399
- Please verify that using id->idReg2() in this branch correctly handles the Zm field encoding for sve_mov as intended, ensuring consistency with the instruction specification.
code |= insEncodeReg_V<20, 16>(id->idReg2()); // mmmmm
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
BruceForstall
approved these changes
Apr 3, 2025
This was referenced Apr 4, 2025
Contributor
Author
|
superpmi-diff failures are because osx/arm64 failed to download collection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My #113860 exposed a bug in encoding of
sve_mov, where we were wrongly skipping the encoding theZmfield and giving wrong instruction.Fixes: #113939