Create error message when UnmanagedCallersOnly is used with DllImport.#114240
Merged
AaronRobinsonMSFT merged 3 commits intodotnet:mainfrom Apr 4, 2025
Merged
Create error message when UnmanagedCallersOnly is used with DllImport.#114240AaronRobinsonMSFT merged 3 commits intodotnet:mainfrom
UnmanagedCallersOnly is used with DllImport.#114240AaronRobinsonMSFT merged 3 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/coreclr/dlls/mscorrc/mscorrc.rc: Language not supported
Comments suppressed due to low confidence (2)
src/coreclr/vm/dllimport.cpp:4293
- Ensure that the additional parameters from GetMethodInfoNoSig (namespaceOrClassName and methodName) are always correctly populated to maintain consistency in the error message formatting.
{
src/coreclr/dlls/mscorrc/resource.h:38
- Verify that the new resource identifier does not conflict with existing IDs and that its value aligns with the overall resource numbering scheme.
#define IDS_EE_NDIRECT_NAMED_UNSUPPORTED_SIG 0x1709
Member
Author
|
Mono doesn't have a consistent error message for this case so I left it "as is". |
am11
reviewed
Apr 3, 2025
jkotas
reviewed
Apr 3, 2025
AaronRobinsonMSFT
requested review from
steveisok,
thaystg and
vitek-karas
as code owners
AaronRobinsonMSFT
changed the title
AaronRobinsonMSFT
changed the title
UnmanagedCallersOnly is used with DllImport.
jkotas
approved these changes
Apr 3, 2025
jkoritzinsky
approved these changes
Apr 3, 2025
This was referenced Apr 4, 2025
Member
Author
|
/ba-g Timeouts and QUIC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92409