Conversation
ghost
added
the
needs-area-label
|
/azp run runtime |
|
Azure Pipelines failed to run 1 pipeline(s). |
elinor-fung
force-pushed
the
hostTests-helix
branch
from
34ff3b5 to
ae7e9ff
Compare
elinor-fung
force-pushed
the
hostTests-helix
branch
3 times, most recently
from
fb99271 to
246c9d9
Compare
| parameters: | ||
| DisplayNamePrefix: Send to Helix | ||
| HelixProjectPath: src/installer/tests/helixpublish.proj | ||
| HelixProjectArguments: /p:Configuration=${{ parameters.buildConfig }} /p:TargetArchitecture=${{ parameters.archType }} /p:TargetRuntimeIdentifier=${{ parameters.targetRid }} /p:TargetOS=${{ parameters.osGroup }} |
There was a problem hiding this comment.
Just curious, if we remove TargetRuntimeIdentifier from here, would it default to OutputRID as before?
There was a problem hiding this comment.
Actually, I think the host tests always use OutputRID, so TargetRuntimeIdentifier is not needed/used (and this is just from using the arguments from libraries tests as reference)
There was a problem hiding this comment.
On this note, I think targetRid (which gets passed to builds as p:TargetRid) shouldn't be needed in eng/pipelines/* in principle as in the code, we compute the OutputRID; except for NonexistentRID (banana.24-x64 dummy RID test leg which is failing for several months) and CentOS9 (centos.9-x64 which is a non-portable RID).
am11
added
area-Infrastructure-installer
and removed
needs-area-label
elinor-fung
force-pushed
the
hostTests-helix
branch
2 times, most recently
from
57d53c9 to
983c96a
Compare
elinor-fung
force-pushed
the
hostTests-helix
branch
from
30d9c38 to
65728d9
Compare
elinor-fung
force-pushed
the
hostTests-helix
branch
from
65728d9 to
2705d22
Compare
elinor-fung
force-pushed
the
hostTests-helix
branch
from
2705d22 to
2051a3d
Compare
|
The packaging tests should really live in Arcade as part of testing the SharedFramework SDK. |
|
Opened #115522 about moving the packaging tests. |
3 participants
Update installer pipelines to send host tests to helix instead of running locally
host-<os>-<arch> @ <helix_queue>This change only handles platforms that we were already running tests on (linux_x64, osx_x64, windown_x64, windows_x86). We would want further updates to add other platforms (for example, arm64, linux_musl).
This does remove running of
Microsoft.DotNet.CoreSetup.Packaging.Teststests in PR/CI. I don't think those are particularly useful at this point - I've haven't seen them fail and find an issue in my time here,Test updates:
Contributes to #77800
cc @dotnet/appmodel