Generating Debug Info for interpreted bytecode#114139
Merged
cshung merged 3 commits intodotnet:mainfrom Apr 3, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (7)
- src/coreclr/inc/cordebuginfo.h: Language not supported
- src/coreclr/interpreter/compiler.cpp: Language not supported
- src/coreclr/interpreter/compiler.h: Language not supported
- src/coreclr/interpreter/compileropt.cpp: Language not supported
- src/coreclr/vm/eetwain.cpp: Language not supported
- src/coreclr/vm/interpexec.cpp: Language not supported
- src/coreclr/vm/stackwalk.cpp: Language not supported
This was referenced Apr 2, 2025
BrzVlad
reviewed
Apr 2, 2025
BrzVlad
reviewed
Apr 2, 2025
BrzVlad
reviewed
Apr 2, 2025
BrzVlad
reviewed
Apr 2, 2025
BrzVlad
reviewed
Apr 2, 2025
BrzVlad
reviewed
Apr 2, 2025
96e8854 to
37b61a8
Compare
BrzVlad
reviewed
Apr 2, 2025
37b61a8 to
48a953d
Compare
BrzVlad
approved these changes
Apr 2, 2025
48a953d to
98bb9c4
Compare
This was referenced Apr 3, 2025
98bb9c4 to
d908781
Compare
Member
|
@cshung I don't actually see the rename from |
Member
|
Also, if we wanted to make a rename like this, it should be done in a separate PR to not to obscure the real change here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change produces the debug info for interpreted byte code.
Changes:
On the compiler:
nativeOffset, so we have the liveness of all variables and the nativeOffset for all instruction.On the stack walker:
SPtopFrame, we also setFPtopFrame->pStack, that is because the offset of the variables are relative topFrame->pStack, and so the debugger needs to know about it, and we chose to report that value through theFP.On the debugger:
REGNUM_FPis not defined for AMD64 and is causing problem, just define it there.The change is tested under SOS so that if we set a breakpoint inside the interpreter routine and do a
!clrstack -i -a, we will be able to see the argument and local variables values.@janvorli
@BrzVlad
@kg
@dotnet/dotnet-diag