[mono][interpreter] Make nint and nuint work for interpreter simd intrinsics#114087
Merged
lewing merged 13 commits intodotnet:mainfrom Apr 3, 2025
Merged
[mono][interpreter] Make nint and nuint work for interpreter simd intrinsics#114087lewing merged 13 commits intodotnet:mainfrom
lewing merged 13 commits intodotnet:mainfrom
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
Member
Author
|
More fixes on the way |
lewing
requested review from
BrzVlad,
kotlarmilos,
steveisok and
vitek-karas
as code owners
Member
Author
|
Need to add a test case |
Member
Author
|
I will backport the runtime abort fixes to net 9 manually. |
4 tasks
steveisok
approved these changes
Apr 3, 2025
kg
reviewed
Apr 3, 2025
Member
Author
|
/ba-g failures are unrelated |
This was referenced Apr 3, 2025
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PackedSimd is currently broken in the interpreter with nint and nuint types because of this, and Vector128 fails to find the intrinsics. Additionally
Vector128<nuint>is used in a potential hot path.runtime/src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf16Utility.Validation.cs
Line 293 in 4b16dce
fixes #114088
Also fixes PackedSimd.Store*, and ConvertToDoubleLower interpreter intrinsics identified by the tests