Skip to content

[main] Update dependencies from dotnet/xharness#114057

Merged
akoeplinger merged 4 commits intomainfrom
darc-main-f70b6bd3-e1cd-41a0-a154-171562b0cbea
Apr 16, 2025
Merged

[main] Update dependencies from dotnet/xharness#114057
akoeplinger merged 4 commits intomainfrom
darc-main-f70b6bd3-e1cd-41a0-a154-171562b0cbea

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 31, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/xharness

@dotnet-maestro
Update dependencies from https://github.com/dotnet/xharness build 202…
463f44d 
…50326.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 10.0.0-prerelease.25167.4 -> To Version 10.0.0-prerelease.25176.1
@ghost ghost added the area-codeflow for labeling automated codeflow label Mar 31, 2025
This was referenced Mar 31, 2025
Open
Closed
Closed
Closed
Closed
This was referenced Apr 3, 2025
Open
Closed
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/xharness build 202…
d379d22 
…50402.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 10.0.0-prerelease.25167.4 -> To Version 10.0.0-prerelease.25202.1
This was referenced Apr 7, 2025
Open
Closed
@matouskozak
Copy link
Member

matouskozak commented Apr 8, 2025

@lewing what are the usual steps to merging updates from xharness?

I see there are some wasm issues (one is still hanging) but these appear to be tracked.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/xharness build 202…
577a734 
…50411.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 10.0.0-prerelease.25167.4 -> To Version 10.0.0-prerelease.25211.1
This was referenced Apr 14, 2025
Closed
Closed
Open
@akoeplinger
Copy link
Member

akoeplinger commented Apr 16, 2025

yeah the wasm failures are unrelated so we can merge

@akoeplinger
Copy link
Member

akoeplinger commented Apr 16, 2025

/ba-g wasm failures are not related to xharness changes

@akoeplinger akoeplinger merged commit f072988 into main Apr 16, 2025
149 of 158 checks passed
@akoeplinger akoeplinger deleted the darc-main-f70b6bd3-e1cd-41a0-a154-171562b0cbea branch April 16, 2025 11:59
@matouskozak
Copy link
Member

matouskozak commented Apr 17, 2025

It looks like my change to xharness (dotnet/xharness#1383) broke the mobile runtime tests build https://dev.azure.com/dnceng-public/public/_build/results?buildId=1018649

2025-04-16T21:22:32.2650400Z /Users/runner/work/1/s/src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs(53,28): error CS0508: 'GeneratedTestRunner.WriteResultsToFile(XmlResultJargon)': return type must be 'Task<string>' to match overridden member 'TestRunner.WriteResultsToFile(XmlResultJargon)' [/Users/runner/work/1/s/src/tests/Common/XHarnessRunnerLibrary/XHarnessRunnerLibrary.csproj] [/Users/runner/work/1/s/src/tests/build.proj]
2025-04-16T21:22:32.2871360Z ##[error]src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs(53,28): error CS0508: 'GeneratedTestRunner.WriteResultsToFile(XmlResultJargon)': return type must be 'Task<string>' to match overridden member 'TestRunner.WriteResultsToFile(XmlResultJargon)' [/Users/runner/work/1/s/src/tests/Common/XHarnessRunnerLibrary/XHarnessRunnerLibrary.csproj]
2025-04-16T21:22:32.3059250Z /Users/runner/work/1/s/src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs(60,26): error CS0508: 'GeneratedTestRunner.WriteResultsToFile(TextWriter, XmlResultJargon)': return type must be 'Task' to match overridden member 'TestRunner.WriteResultsToFile(TextWriter, XmlResultJargon)' [/Users/runner/work/1/s/src/tests/Common/XHarnessRunnerLibrary/XHarnessRunnerLibrary.csproj] [/Users/runner/work/1/s/src/tests/build.proj]
2025-04-16T21:22:32.3221830Z ##[error]src/tests/Common/XHarnessRunnerLibrary/GeneratedTestRunner.cs(60,26): error CS0508: 'GeneratedTestRunner.WriteResultsToFile(TextWriter, XmlResultJargon)': return type must be 'Task' to match overridden member 'TestRunner.WriteResultsToFile(TextWriter, XmlResultJargon)' [/Users/runner/work/1/s/src/tests/Common/XHarnessRunnerLibrary/XHarnessRunnerLibrary.csproj]

@matouskozak
Copy link
Member

matouskozak commented Apr 17, 2025 •
edited
Loading

The range of commits when the regression happened is d97ad23...bdd0dae . Looking at the error message I think it might be caused by dotnet/xharness#1388 cc: @pavelsavara

@matouskozak
Copy link
Member

matouskozak commented Apr 17, 2025

Looks like you already have a fix #114746 merged. I'll wait for next runtime-extra-platforms rolling build to confirm it is resolved.

@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees

No one assigned

Labels

area-codeflow for labeling automated codeflow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matouskozak @akoeplinger @lewing