remove the switch to fallback to old EH#114018
Merged
mangod9 merged 5 commits intodotnet:mainfrom Apr 1, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 18 changed files in this pull request and generated no comments.
Files not reviewed (17)
- src/coreclr/debug/daccess/dacdbiimplstackwalk.cpp: Language not supported
- src/coreclr/debug/ee/debugger.cpp: Language not supported
- src/coreclr/inc/clrconfigvalues.h: Language not supported
- src/coreclr/inc/dacvars.h: Language not supported
- src/coreclr/vm/clrex.cpp: Language not supported
- src/coreclr/vm/debugdebugger.cpp: Language not supported
- src/coreclr/vm/excep.cpp: Language not supported
- src/coreclr/vm/excep.h: Language not supported
- src/coreclr/vm/fcall.cpp: Language not supported
- src/coreclr/vm/fcall.h: Language not supported
- src/coreclr/vm/jithelpers.cpp: Language not supported
- src/coreclr/vm/prestub.cpp: Language not supported
- src/coreclr/vm/proftoeeinterfaceimpl.cpp: Language not supported
- src/coreclr/vm/stackwalk.cpp: Language not supported
- src/coreclr/vm/threadsuspend.cpp: Language not supported
- src/coreclr/vm/vars.cpp: Language not supported
- src/coreclr/vm/vars.hpp: Language not supported
ghost
added
the
Contributor
|
Tagging subscribers to this area: @mangod9 |
This was referenced Mar 28, 2025
rhuijben
reviewed
Mar 28, 2025
| { | ||
| HandleManagedFault(pExceptionInfo->ExceptionRecord, pExceptionInfo->ContextRecord); | ||
| } | ||
| HandleManagedFault(pExceptionInfo->ExceptionRecord, pExceptionInfo->ContextRecord); |
Contributor
There was a problem hiding this comment.
This one is not just removing checks, like in other places.
Member
Author
There was a problem hiding this comment.
Can you please elaborate? HandleManagedFaultNew is now renamed HandleManagedFault
rhuijben
reviewed
Mar 28, 2025
rhuijben
reviewed
Mar 28, 2025
Member
Author
|
/ba-g failures are dotnet/dnceng#5279 |
thaystg
pushed a commit
to thaystg/runtime
that referenced
this pull request
Apr 1, 2025
* remove the switch to fallback to old EH * more cleanup * fix build break after merge. * CR feedback
Member
|
There's a lot more that can be cleaned up. At first look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial PR to remove the switch to fallback to Legacy EH except for x86.
There is more cleanup that can be done, but that would be done as a separate PR.