[cDAC] Remove superfluous modifiers from contract interfaces#113983
Merged
max-charlamb merged 2 commits intodotnet:mainfrom Apr 1, 2025
Merged
[cDAC] Remove superfluous modifiers from contract interfaces#113983max-charlamb merged 2 commits intodotnet:mainfrom
max-charlamb merged 2 commits intodotnet:mainfrom
Conversation
ghost
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes redundant modifiers from contract interface method declarations to adhere to modern C# practices.
- Removed explicit "public virtual" modifiers from interface members in multiple files.
- Updated method signatures across various contract interfaces for consistency.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| IStressLog.cs | Removed modifiers from interface methods. |
| IStackWalk.cs | Removed redundant modifiers from interface methods. |
| IRuntimeTypeSystem.cs | Removed explicit modifiers from numerous interface methods. |
| IObject.cs | Removed modifiers from interface methods. |
| ILoader.cs | Removed modifiers from interface methods. |
| IException.cs | Removed modifiers from interface methods. |
| IEcmaMetadata.cs | Removed modifiers from interface methods. |
| IDacStreams.cs | Removed modifiers from interface methods. |
Comments suppressed due to low confidence (1)
src/native/managed/cdacreader/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStressLog.cs:40
- [nitpick] The parameter name 'Logs' is in PascalCase; consider renaming it to 'logs' to follow typical camelCase conventions for parameter names.
IEnumerable<ThreadStressLogData> GetThreadStressLogs(TargetPointer Logs) => throw new NotImplementedException();
davmason
approved these changes
Mar 27, 2025
Member
Author
|
/azp run runtime-diagnostics |
|
Azure Pipelines successfully started running 1 pipeline(s). |
max-charlamb
added
area-Diagnostics-coreclr
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @tommcdon |
jkoritzinsky
approved these changes
Mar 27, 2025
This was referenced Mar 27, 2025
3 tasks
Member
Author
|
/ba-g #113883 Known tests failures are unrelated |
thaystg
pushed a commit
to thaystg/runtime
that referenced
this pull request
Apr 1, 2025
…113983) * remove superfluous modifiers `public virtual` from contract interfaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#113769 (comment)