Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Made the suggested changes + tentatively fix test by filtering Inlining requests per module name)

I could use some help diagnosing what is happening with https://dev.azure.com/dnceng-public/public/_build/results?buildId=1000924&view=logs&jobId=3e93a48f-6568-53f2-76b3-1285c183c39d&j=3e93a48f-6568-53f2-76b3-1285c183c39d&t=313dc435-bc2e-554b-c5b1-106790cdfaec.

I could use some help diagnosing what is happening with https://dev.azure.com/dnceng-public/public/_build/results?buildId=1000924&view=logs&jobId=3e93a48f-6568-53f2-76b3-1285c183c39d&j=3e93a48f-6568-53f2-76b3-1285c183c39d&t=313dc435-bc2e-554b-c5b1-106790cdfaec.

Adding @lewing as this looks like WASM testing

I think the other failures are unrelated known instabilities

Per review comments, did:

• remove debug bits macro, encapsulating it in the helper method (actually enforcing both debugger and profiler bits are checked)
• moved IsInliningDisabledByProfiler check within PROFILING_SUPPORTED and returning the same INLINING_FAIL result as initially
• removed some redundant #ifdefs
• reviewed both C# and C++ formatting (it does not help that all clang-format / clang-tidy rules are removed at the root of the repo)

Last round of update:

• restored CORDebuggerAllowJITOpts macro, with a comment about preferring to call Module::AreJITOptimizationsDisabled()
• reorganized commit history (it was starting to be a mess)
• rebased to tentatively get any potential fixes for the seemingly unrelated build/test failures

Rebase brought new build failures - but it seems they are their on tip of main branch as well

Should I worry about the build / test failures ? they all seem unrelated but could use confirmation

The Build Analysis pipeline should be green before we merge. It uses known issues to filter out failing checks, so the 3 other pipelines that are failing Build Libraries Test Run checked coreclr linux x64 Release, Build osx-x64 Release AllSubsets Mono Minijit RuntimeTests minijit, and Build osx-x64 Release NativeAOT have failures that either are

1. directly caused by this PR - Should fix
2. not related to this PR and there is no known issue linked to the failure - Should create a new issue to regex match the failure
3. not related to this PR and there is a known issue linked to the failure, but the regex matching couldn't match it - should either fix the regex matching or mention in the issue that the failure also occured in this PR

Build Analysis Overview

All the Build Libraries Test Run checked coreclr linux x64 Release are known issues #114152 #113883 and #107761

I think the OSX failures are some bad machine configuration.

@simonferquel, in addition to Jan's feedback, there are also conflicts in src/tests/profiler/native/CMakeLists.txt and src/tests/profiler/native/classfactory.cpp because
#114107 also added a profiler test

I rebased and fixed conflict. I also opened a dummy draft PR (removing an empty line of code) to compare build results (so that I do not introduce regression by feeling a flakky test issue)

Build analysis is green, thanks for the help working on that one :)