Adjust additional source under utilcode and vm to use minipal_log API.#113916
Conversation
ghost
added
the
There was a problem hiding this comment.
Copilot reviewed 3 out of 23 changed files in this pull request and generated no comments.
Files not reviewed (20)
- src/coreclr/utilcode/debug.cpp: Language not supported
- src/coreclr/utilcode/executableallocator.cpp: Language not supported
- src/coreclr/utilcode/loaderheap.cpp: Language not supported
- src/coreclr/utilcode/util_nodependencies.cpp: Language not supported
- src/coreclr/vm/assembly.cpp: Language not supported
- src/coreclr/vm/binder.cpp: Language not supported
- src/coreclr/vm/ceemain.cpp: Language not supported
- src/coreclr/vm/class.cpp: Language not supported
- src/coreclr/vm/classcompat.cpp: Language not supported
- src/coreclr/vm/codeman.h: Language not supported
- src/coreclr/vm/codepitchingmanager.cpp: Language not supported
- src/coreclr/vm/debughelp.cpp: Language not supported
- src/coreclr/vm/disassembler.cpp: Language not supported
- src/coreclr/vm/ecall.cpp: Language not supported
- src/coreclr/vm/eetwain.cpp: Language not supported
- src/coreclr/vm/frames.cpp: Language not supported
- src/coreclr/vm/gchelpers.cpp: Language not supported
- src/coreclr/vm/gdbjit.cpp: Language not supported
- src/coreclr/vm/hash.cpp: Language not supported
- src/coreclr/vm/jithelpers.cpp: Language not supported
|
Tagging subscribers to this area: @mangod9 |
|
Failures in [runtime "Build Libraries Test Run checked coreclr linux x64 Release" appears on other PR's as well, so unrelated. |
|
@janvorli Thanks for review, I did change existing logging since I didn't have too much experience of their usage, so primarily just did a straight adaption so if it used stdout it was ported to info and if it used strerr it was ported to error. I will go over your comment and adjust loggings based on feedback. Thanks! |
|
@janvorli addressed all your review feedback. |
janvorli
left a comment
janvorli
left a comment
There was a problem hiding this comment.
I am sorry, I've missed some places that should go to error in my previous PR.
|
@janvorli changed the called-out logging from info -> error, please make another review when you have time. |
|
Same test failures in "Build Libraries Test Run checked coreclr linux x64 Release" appears on other PR's. |
lateralusX
force-pushed
the
lateralusX/additional-coreclr-android-logging
branch
from
8f3462b to
6cd01d3
Compare
|
/ba-g the failures are the tests that keep failing on the azure linux for all PRs. |
#113416 established a logging API in native/minipal wired up to work on platforms not supporting standard stdout/stderr, like Android. That initial PR changed a couple of locations from regular printf's to minipal_log calls.
This follow-up PR adjust more locations inside coreclr utilcode and vm folder using minipal_log API's for logging. There are still a couple of places that have not been adjusted, mainly due to unactive code (commented out or #if 0) and the code in src\coreclr\vm\gc_unwind_x86.inl was intestinally left out.
There are more places that could be adjusted to use minipal_log API's instead of straight printf's, like the pal, nativeaot, but going forward, this could be done on a case-by-case basis, if the specific logging is needed on platforms without working stdout/stderr.