Skip to content

Include xmmintrin.h early on x86 as well#113279

Merged
jkoritzinsky merged 2 commits intodotnet:mainfrom
jkoritzinsky:x86-xmmintrin
Mar 13, 2025
Merged

Include xmmintrin.h early on x86 as well#113279
jkoritzinsky merged 2 commits intodotnet:mainfrom
jkoritzinsky:x86-xmmintrin

Conversation

@jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented Mar 7, 2025 •
edited by richlander
Loading

We're hitting problems with our debugreturn.h machinery on x86 with Clang 20. Include xmmintrin.h early on that platform as well to work around it.

Related: #113248

Copilot AI review requested due to automatic review settings March 7, 2025 21:47
Copilot AI reviewed Mar 7, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@ghost ghost added the area-VM-coreclr label Mar 7, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Mar 7, 2025

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@am11
Copy link
Member

am11 commented Mar 7, 2025

The other error is:

[ 86%] Linking CXX shared library libDllImportPath_Relative.so
/__w/1/s/src/tests/Interop/DllImportAttribute/DllImportPath/DllImportPathNative.cpp:13:24: error: 'main' should not be 'extern "C"' [-Werror,-Wmain]
   13 | extern "C" int __cdecl main(int argc,  char **argv)
      |                        ^

@richlander
Copy link
Member

richlander commented Mar 8, 2025

Thanks for your help @am11!

@am11
Copy link
Member

am11 commented Mar 8, 2025 •
edited
Loading

@jkoritzinsky I think we can remove extern "C" from this line

runtime/src/tests/Interop/DllImportAttribute/DllImportPath/DllImportPathNative.cpp

Line 13 in 2ec50bd

extern "C" int __cdecl main(int argc, char **argv)
as part of this PR or a separate one. With that, the builds on 64-bit platforms also succeed.

@build-analysis build-analysis bot mentioned this pull request Mar 8, 2025
Closed
@mthalman mthalman mentioned this pull request Mar 12, 2025
Merged
sbomer
sbomer approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jkoritzinsky and @am11!

@jkoritzinsky jkoritzinsky merged commit cc01298 into dotnet:main Mar 13, 2025
101 checks passed
@jkoritzinsky jkoritzinsky deleted the x86-xmmintrin branch March 13, 2025 17:48
@jkoritzinsky jkoritzinsky mentioned this pull request Mar 24, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@sbomer sbomer sbomer approved these changes

@jkotas jkotas jkotas approved these changes

@richlander richlander Awaiting requested review from richlander

@hoyosjs hoyosjs Awaiting requested review from hoyosjs

Assignees

@jkoritzinsky jkoritzinsky

Labels

area-VM-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jkoritzinsky @am11 @richlander @sbomer @jkotas