JIT: Don't move blocks during return merging#113278
Closed
amanasifkhalid wants to merge 2 commits intodotnet:mainfrom
Closed
JIT: Don't move blocks during return merging#113278amanasifkhalid wants to merge 2 commits intodotnet:mainfrom
amanasifkhalid wants to merge 2 commits intodotnet:mainfrom
Conversation
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
Author
|
Since we limit the number of epilogues to 4 at the moment, the TP cost of emitting additional branches due to the loss of fallthrough in MinOpts exceeds the TP gain from not moving the return blocks up to their successors. It's not worth pursuing this now, but it's worth reconsidering if we ever increase the number of epilogues allowed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While removing the old block layout code, I noticed return merging has a step for moving return blocks up to their ideal predecessors to make up for deficiencies in block reordering that no longer exist. Removing this step adds jumps to newly added return blocks in MinOpts, and incurs a few diffs from
fgUpdateFlowGraphchurn in FullOpts; both seem acceptable.