[APX] Complete EGPR encoding in X64 backend #113237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Mar 7, 2025
Open
Member
Author
|
The failures look irrelevant, PR is ready for review. |
huoyaoyuan
added
the
apx
Member
Author
|
Hi @tannergooding @BruceForstall This PR is ready for review, appreciate for any feedback. :) |
| case INS_pdep: | ||
| case INS_mulx: | ||
| // TODO: Unblock when enabled for x86 | ||
| #ifdef TARGET_AMD64 |
Contributor
There was a problem hiding this comment.
Looks like this will get enabled by #111778, after which these ifdefs can be removed. Not sure which will get merged first.
Contributor
|
/ba-g OSX infra issue |
Member
Author
|
Thanks for the quick response! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #106557 and #108796, we introduced APX new encodings - REX2 and extended EVEX, and with #108799, we introduced more general-purpose registers (EGPRs) in register allocator.
This PR addresses some left-over changes needed in the emitter to let both REX2 and extended EVEX address EGPRs properly.
Plus it introduced more APX compatible instructions.
Note that this PR only covers the encoding part and is not intended to let register allocator consider EGPR in more instructions/nodes. We are planning this part later. So this PR is expected to have no asmdiff with/without APX.