[release/9.0-staging] Backport "Ship CoreCLR packages in servicing releases"#113026
Merged
amanasifkhalid merged 1 commit intodotnet:release/9.0-stagingfrom Mar 4, 2025
Merged
Conversation
ghost
added
the
Contributor
Author
|
@jkoritzinsky PTAL, thanks! I don't know if there are 8.0 fixes to these packages that are waiting to propagate, but should we backport this to 8.0 as well, just for good measure? |
Contributor
|
Tagging subscribers to this area: @hoyosjs |
jeffschwMSFT
approved these changes
Feb 28, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. please get a code review. we will take for consideration in 9.0.x
jeffschwMSFT
added
the
Servicing-consider
jkoritzinsky
approved these changes
Feb 28, 2025
ericstj
approved these changes
Mar 4, 2025
rbhanda
added
Servicing-approved
amanasifkhalid
merged commit f18ca7d
into
dotnet:release/9.0-staging
96 of 99 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #113020 to release/9.0-staging
Customer Impact
An attempt to backport #111444 revealed that CoreCLR packages (like ILAsm/ILDasm) aren't published in servicing releases, meaning fixes to these packages aren't reaching customers. As identified in #112710 (comment), there are some non-CoreCLR packages that also aren't being shipped in servicing releases, but probably should be.
Regression
As far as I know, there was never a conscious decision to stop updating these packages in servicing releases.
Testing
An official build of
release/9.0-stagingwith CoreCLR packages enabled for shipping passed, and I verified in the package manifest that these packages were shipped. Some manual verification that these packages were shipped in the next servicing release would be prudent.Risk
Low. While this will change the versions of the packages available to customers, I suspect few customers were using these packages to begin with, considering it took us this long to notice this.