[NRBF] Remove [Experimental]#113021
Merged
adamsitnik merged 2 commits intodotnet:mainfrom Mar 5, 2025
Merged
Conversation
…SYSLIB5005 (dotnet#107905)" This reverts commit b08181b. # Conflicts: # docs/project/list-of-diagnostics.md # src/libraries/Common/src/System/Experimentals.cs # src/libraries/System.Formats.Nrbf/src/System.Formats.Nrbf.csproj
ghost
added
the
|
Note regarding the |
1 similar comment
|
Note regarding the |
Contributor
There was a problem hiding this comment.
PR Overview
This pull request reverts the experimental features for System.Formats.Nrbf by removing the experimental diagnostic identifier and associated attributes and documentation.
- Removed the Nrbf experimental diagnostic constant and updated its comment in Experimentals.cs
- Changed ExperimentalAttribute to be public rather than conditionally internal in CoreLib
- Removed experimental API annotations from AssemblyInfo.cs and the reference assembly file, and updated PACKAGE.md accordingly
Reviewed Changes
| File | Description |
|---|---|
| src/libraries/Common/src/System/Experimentals.cs | Removed the constant for the experimental diagnostic identifier and updated its comment to discourage reuse |
| src/libraries/System.Private.CoreLib/src/System/Diagnostics/CodeAnalysis/ExperimentalAttribute.cs | Made the ExperimentalAttribute public unconditionally |
| src/libraries/System.Formats.Nrbf/src/PACKAGE.md | Removed the note indicating that the package is experimental |
| src/libraries/System.Formats.Nrbf/src/AssemblyInfo.cs | Removed the assembly-level experimental attribute |
| src/libraries/System.Formats.Nrbf/ref/System.Formats.Nrbf.Experimental.cs | Removed the reference assembly experimental attribute |
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
stephentoub
approved these changes
Feb 28, 2025
jeffhandley
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a revert of #107905 with some minor changes applied in 4ad72fd
If anyone has any feedback regarding the API shape, please speak up!
BTW once it's gets merged I am going to revert dotnet/wpf#9791 and dotnet/winforms#12156