Optimize bit operations of BigInteger#113005
Merged
tannergooding merged 4 commits intodotnet:mainfrom Sep 17, 2025
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
huoyaoyuan
reviewed
Feb 28, 2025
src/libraries/System.Runtime.Numerics/src/System/Numerics/NumericsHelpers.cs
Show resolved
Hide resolved
src/libraries/System.Runtime.Numerics/src/System/Numerics/NumericsHelpers.cs
Show resolved
Hide resolved
src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs
Outdated
Show resolved
Hide resolved
3 tasks
Member
|
@tannergooding I know we've talked (for a long time) about substantial overhauls (rewrites) of how BigInteger is implemented, and I have been sitting on this PR (sorry, @kzrnm) for a long time because I've been unsure if we should take incremental but still sizeable changes. I'm inclined to accept this change though, even if we do end up doing more substantial work later. What do you think? |
tannergooding
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a refactored version of #112632.
Benchmark