Fixed Tensor Conversion Test #112703
Merged
Fixed Tensor Conversion Test #112703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelgsharp
requested review from
eiriktsarpalis,
jkotas and
tannergooding
ghost
added
the
tannergooding
approved these changes
Feb 19, 2025
grendello
pushed a commit
to grendello/runtime
that referenced
this pull request
Feb 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112286.
We had a section of tests that should never overflow, but we had double -> float instead of double -> double. This was causing the issue when the randomly generated double wouldn't fit into the float.