Set AppContext.BaseDirectory and the lookup path for AssemblyDirectory to the directory containing the NativeAOT module by jkoritzinsky · Pull Request #112457 · dotnet/runtime

jkoritzinsky · 2025-02-11T23:01:28Z

We already had most of the components needed to wire this up in the NativeAOT PAL and in the EH DeveloperExperience APIs, so this wasn't as bad as I thought.

…y to the directory containing the NativeAOT module

MichalStrehovsky · 2025-02-17T05:55:13Z

Could you add a test for this? I assume since this still doesn't build, it wasn't even manually tested to work, and we definitely don't have test coverage in the tree.

jkoritzinsky · 2025-02-17T07:42:09Z

Yes I need to still construct a test for this. I'll flip it to draft until I have it ready for review.

src/coreclr/nativeaot/System.Private.CoreLib/src/System/AppContext.NativeAot.cs

jkoritzinsky · 2025-02-24T19:57:05Z

@MichalStrehovsky I've added a test for this.

src/coreclr/nativeaot/System.Private.CoreLib/src/System/AppContext.NativeAot.cs

src/tests/nativeaot/SmokeTests/SharedLibraryDependencyLoading/SharedLibraryHost.cpp

MichalStrehovsky

The tests are failing but it looks reasonable to me otherwise, thanks!

Just last week I was helping someone in the Windows org who was building a DLL and wondered why they can't load a JSON file next to the DLL with AppContext.BaseDirectory.

I wonder if we should doc this as a breaking change, someone might use this and it would be nice to have guidance ready (just use the directory of the Environment.ProcessPath).

jkoritzinsky · 2025-02-25T17:05:28Z

I'll mark this as a breaking change and file the doc after I fix the test and merge.

elinor-fung

It might also be good to add a note to the DllImportSearchPath.AssemblyDirectory doc about Native AOT libraries.

src/tests/nativeaot/SmokeTests/SharedLibraryDependencyLoading/SharedLibraryDependency.cpp

src/tests/nativeaot/SmokeTests/SharedLibraryDependencyLoading/SharedLibraryDependencyLoading.cs

…re relative to the current working directory.

MichalStrehovsky · 2025-03-05T06:23:43Z

Native AOT outerloop runs are broken: many tests failing with "The path must be absolute":

[FAIL] Microsoft.Extensions.Hosting.Tests.HostBuilderTests.DefaultConfigIsMutable
System.ArgumentException : The path must be absolute. (Parameter 'root')
   at Microsoft.Extensions.FileProviders.PhysicalFileProvider..ctor(String, ExclusionFilters) + 0xe0
   at Microsoft.Extensions.Hosting.HostBuilder.CreateHostingEnvironment(IConfiguration) + 0x118
   at Microsoft.Extensions.Hosting.HostBuilder.Build() + 0x3b
   at Microsoft.Extensions.Hosting.Tests.HostBuilderTests.DefaultConfigIsMutable() + 0x2c
   at Microsoft.Extensions.Hosting.Unit!<BaseAddress>+0x1db881b
   at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0x118

If I'm reading this right the problem is that we somehow end up using the path of argv[0] as the AppContext.BaseDirectory, but that can be a relative path relative to the current directory at process start. (I didn't actually try to debug this, I just worked backwards from the newly added test for BaseDirectory that uses argv[0] as the expected value.)

If this cannot be fixed quickly, I'd prefer this to be reverted because it's failing 100 tests and it's hard to keep an eye on outerloop with so many failures.

MichalStrehovsky · 2025-03-05T06:26:42Z

Sample outerloop run with the failures: https://dev.azure.com/dnceng-public/public/_build/results?buildId=968880&view=logs&j=7e7cde7f-4669-5f41-976b-370a74291e60&t=e3f1bc70-511c-5e38-2600-aec10f79e344

jkoritzinsky · 2025-03-05T15:19:48Z

I'll take a look today and if I can't fix it I'll revert it.

ericstj · 2025-10-03T20:48:58Z

📋 Breaking Change Documentation Required

Create a breaking change issue with AI-generated content

Generated by Breaking Change Documentation Tool - 2025-10-03 13:48:57

jkoritzinsky · 2025-10-03T21:26:29Z

We reverted this, so we don't need a doc for it.

Set AppContext.BaseDirectory and the lookup path for AssemblyDirector…

5f90ffa

…y to the directory containing the NativeAOT module

jkoritzinsky requested a review from MichalStrehovsky as a code owner February 11, 2025 23:01

ghost added the area-NativeAOT-coreclr label Feb 11, 2025

dotnet-policy-service bot assigned jkoritzinsky Feb 11, 2025

max-charlamb mentioned this pull request Feb 13, 2025

[cDAC] Implement core stackwalking #111759

Merged

Fix calling convention

5ad0b1b

This was referenced Feb 15, 2025

XHarness message of order error leading to timeout dotnet/dnceng#4823

Closed

[wasm][AOT][net8.0] emcc : error - received SIGKILL (-9) #89402

Open

MichalStrehovsky requested review from AaronRobinsonMSFT and elinor-fung February 17, 2025 05:55

jkoritzinsky marked this pull request as draft February 17, 2025 07:43

Fix missing using

0bb7c80

AaronRobinsonMSFT reviewed Feb 18, 2025

View reviewed changes

src/coreclr/nativeaot/System.Private.CoreLib/src/System/AppContext.NativeAot.cs Outdated Show resolved Hide resolved

This was referenced Feb 18, 2025

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

jkoritzinsky added 3 commits February 20, 2025 10:54

Rewrite an add comment

bba4f9e

Add test

aaf93c7

Merge branch 'main' into nativeaot-appcontext-base

6f42c19

jkoritzinsky marked this pull request as ready for review February 24, 2025 19:56

jkoritzinsky requested a review from AaronRobinsonMSFT February 24, 2025 19:56

AaronRobinsonMSFT reviewed Feb 24, 2025

View reviewed changes

src/coreclr/nativeaot/System.Private.CoreLib/src/System/AppContext.NativeAot.cs Show resolved Hide resolved

AaronRobinsonMSFT reviewed Feb 24, 2025

View reviewed changes

src/tests/nativeaot/SmokeTests/SharedLibraryDependencyLoading/SharedLibraryHost.cpp Show resolved Hide resolved

AaronRobinsonMSFT approved these changes Feb 24, 2025

View reviewed changes

Make TryGetFullPathToApplicationModule nullable

6f871eb

build-analysis bot mentioned this pull request Feb 25, 2025

SslStreamNetworkStreamTest failures "The remote certificate is invalid because of errors in the certificate chain: PartialChain" #112856

Closed

MichalStrehovsky approved these changes Feb 25, 2025

View reviewed changes

jkoritzinsky added the breaking-change Issue or PR that represents a breaking API or functional change over a previous release. label Feb 25, 2025

dotnet-policy-service bot added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Feb 25, 2025

elinor-fung approved these changes Feb 25, 2025

View reviewed changes

src/tests/nativeaot/SmokeTests/SharedLibraryDependencyLoading/SharedLibraryDependency.cpp Show resolved Hide resolved

src/tests/nativeaot/SmokeTests/SharedLibraryDependencyLoading/SharedLibraryDependencyLoading.cs Show resolved Hide resolved

jkoritzinsky added 3 commits February 25, 2025 11:11

Don't use relative paths to load dependencies on Linux/macos. Those a…

85ebfee

…re relative to the current working directory.

Add test for AppContext.BaseDirectory

43e78ad

Fix test on Windows

e874ec0

AaronRobinsonMSFT approved these changes Feb 25, 2025

View reviewed changes

jkoritzinsky merged commit 7cfe5e3 into dotnet:main Mar 4, 2025
136 of 140 checks passed

jkoritzinsky mentioned this pull request Mar 5, 2025

Handle relative path loading on non-Windows for AppContext.BaseDirectory on NativeAOT #113171

Closed

MichalStrehovsky mentioned this pull request Mar 6, 2025

Revert "Set AppContext.BaseDirectory and the lookup path for AssemblyDirectory to the directory containing the NativeAOT module" #113211

Merged

github-actions bot locked and limited conversation to collaborators Apr 5, 2025

jkoritzinsky removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 3, 2025

Conversation

jkoritzinsky commented Feb 11, 2025

Uh oh!

MichalStrehovsky commented Feb 17, 2025

Uh oh!

jkoritzinsky commented Feb 17, 2025

Uh oh!

Uh oh!

jkoritzinsky commented Feb 24, 2025

Uh oh!

Uh oh!

Uh oh!

MichalStrehovsky left a comment

Choose a reason for hiding this comment

Uh oh!

jkoritzinsky commented Feb 25, 2025

Uh oh!

elinor-fung left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MichalStrehovsky commented Mar 5, 2025

Uh oh!

MichalStrehovsky commented Mar 5, 2025

Uh oh!

jkoritzinsky commented Mar 5, 2025

Uh oh!

ericstj commented Oct 3, 2025

📋 Breaking Change Documentation Required

Uh oh!

jkoritzinsky commented Oct 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants