Add Random.Get{Hex}String #112162
Merged
Add Random.Get{Hex}String #112162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
needs-area-label
|
Note regarding the |
1 similar comment
|
Note regarding the |
This was referenced Feb 5, 2025
Open
stephentoub
added
area-System.Runtime
and removed
needs-area-label
bartonjs
reviewed
Feb 19, 2025
src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/Random.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Feb 19, 2025
src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/Random.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Feb 19, 2025
src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/Random.cs
Outdated
Show resolved
Hide resolved
stephentoub
commented
Feb 19, 2025
src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/Random.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeremy Barton <[email protected]>
…ests/System/Random.cs Co-authored-by: Jeremy Barton <[email protected]>
bartonjs
approved these changes
Feb 19, 2025
Member
|
@stephentoub @bartonjs should we add a note to dotnet/core#9824? |
Member
Author
|
It's a small helper. We could. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111956
I chose not to adopt RandomNumberGenerator's much more complex GetHexString implementation and instead went with a simple wrapper for GetString. We can evaluate based on perf testing whether it'd be worthwhile to do so, but my expectation is the uses for GetHexString will involve shorter sequences where the perf differential will not huge.