Skip to content

JIT: Optimize bit-wise and operation and compare with same constant value#111933

Merged
BruceForstall merged 6 commits intodotnet:mainfrom
varelen:jit-optimize-bit-wise-and-with-constant-compare-issue-101000
Apr 23, 2025
Merged

JIT: Optimize bit-wise and operation and compare with same constant value#111933
BruceForstall merged 6 commits intodotnet:mainfrom
varelen:jit-optimize-bit-wise-and-with-constant-compare-issue-101000

Conversation

@varelen
Copy link
Contributor

@varelen varelen commented Jan 28, 2025 •
edited
Loading

This pull request resolves #101000 and is based on the feedback that was given on the original PR #103868. Thanks for the previous work, it was a really great way to get started.

The code emitted for:

void Foo(int x)
{
    if ((x & 0xC000000) == 0xC000000)
        Console.WriteLine();
}

x64 (before):

and     edi, 0xC000000
cmp     edi, 0xC000000
jne     SHORT G_M000_IG04

x64 (after):

not      edi
and      edi, 0xC000000
jne      SHORT G_M000_IG04

ARM64 (before):

and	w0, w0, #0xC000000
mov	w1, #0xC000000
cmp	w0, w1
bne	G_M29168_IG04

ARM64 (after):

mvn	w0, w0
and	w0, w0, #0xC000000
cbnz	w0, G_M29168_IG04

@varelen
JIT: Optimize bit-wise and operation and compare with same constant v…
7a1ae17 
…alue

This change optimizes bit-wise and with compare patterns like '(x & <constant>) == <constant>'

Fix dotnet#101000
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 28, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 28, 2025
@varelen varelen marked this pull request as ready for review February 4, 2025 17:19
@jakobbotsch jakobbotsch reopened this Feb 24, 2025
@jakobbotsch
Copy link
Member

jakobbotsch commented Feb 24, 2025

Thanks for the contribution! I closed/reopened this to kick off a fresh run of the CI.

cc @dotnet/jit-contrib

EgorBo
EgorBo reviewed Feb 24, 2025
View reviewed changes
src/coreclr/jit/lower.cpp
}
#endif
}
else if (andOp2->IsIntegralConst() && GenTree::Compare(andOp2, op2))
Copy link
Member

@EgorBo EgorBo Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you leave a comment of what this transformation does?

Copy link
Contributor Author

@varelen varelen Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment, hope it's okay.

This was referenced Feb 24, 2025
Closed
Open
Open
@EgorBo
Copy link
Member

EgorBo commented Feb 25, 2025

/azp run Fuzzlyn

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 25, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@JulieLeeMSFT
Copy link
Member

JulieLeeMSFT commented Mar 24, 2025

@EgorBo, please review this community PR again.

@build-analysis build-analysis bot mentioned this pull request Mar 24, 2025
Closed
@JulieLeeMSFT
Copy link
Member

JulieLeeMSFT commented Apr 14, 2025

@BruceForstall, please review this community PR.

@JulieLeeMSFT JulieLeeMSFT removed the request for review from EgorBo April 14, 2025 15:54
@BruceForstall
Copy link
Contributor

BruceForstall commented Apr 21, 2025

/azp run Fuzzlyn, runtime-coreclr outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 21, 2025

Azure Pipelines successfully started running 2 pipeline(s).

@BruceForstall
Copy link
Contributor

BruceForstall commented Apr 23, 2025

/ba-g unrelated failures

@BruceForstall BruceForstall merged commit a37502b into dotnet:main Apr 23, 2025
163 of 168 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBo EgorBo EgorBo left review comments

+1 more reviewer

@BruceForstall BruceForstall BruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JIT: Optimize "x & cns == cns" pattern

5 participants

@varelen @jakobbotsch @EgorBo @JulieLeeMSFT @BruceForstall