[release/9.0-staging] Fixed android build with NDK 23#111696
Merged
jkurdek merged 1 commit intodotnet:release/9.0-stagingfrom Jan 31, 2025
Merged
[release/9.0-staging] Fixed android build with NDK 23#111696jkurdek merged 1 commit intodotnet:release/9.0-stagingfrom
jkurdek merged 1 commit intodotnet:release/9.0-stagingfrom
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to 'arch-android': @vitek-karas, @simonrozsival, @steveisok, @akoeplinger |
ivanpovazan
approved these changes
Jan 22, 2025
This was referenced Jan 22, 2025
Closed
Closed
jkoritzinsky
approved these changes
Jan 22, 2025
jeffschwMSFT
approved these changes
Jan 30, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we can treat this as tell mode and merge when ready
Member
|
@jkurdek can you take a look at the CI failures? we can merge when ready |
Contributor
Author
|
/ba-g CI failures are unrelated, android jobs passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer Impact
Building locally mono android with NDK 23 leads to an error where
_LibClangitem holds two different paths at once. The problem was caused by_LibClangbeing treated like a property inprojfile while being an item. This PR fixes the issue by referring to it using@instead of$.Fixes #111695.
Regression
The bug was introduced to .NET 9 branch in 63cb882 to fix .NET 9 CI after NDK 27 bump.
Testing
This affects the local build only (as we build .NET 9 with NDK 27) so I verified locally that the error is no longer present.
Risk
Very low.