[android] Internal Android sample build improvements and CoreCLR support#111545
Merged
ivanpovazan merged 15 commits intodotnet:mainfrom Jan 29, 2025
Merged
[android] Internal Android sample build improvements and CoreCLR support#111545ivanpovazan merged 15 commits intodotnet:mainfrom
ivanpovazan merged 15 commits intodotnet:mainfrom
Conversation
ivanpovazan
added
NO-MERGE
ghost
added
the
Member
Author
|
/azp run runtime-android, runtime-androidemulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
Author
|
/azp run runtime-android, runtime-androidemulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ivanpovazan
force-pushed
the
helloandroid
branch
from
324207b to
99460e7
Compare
Member
Author
|
/azp run runtime-android, runtime-androidemulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
Author
|
/azp run runtime-android, runtime-androidemulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ivanpovazan
changed the title
ivanpovazan
added
os-android
and removed
NO-MERGE
ivanpovazan
requested review from
akoeplinger,
steveisok and
vitek-karas
as code owners
ivanpovazan
requested review from
akoeplinger,
jkurdek and
steveisok
and removed request for
akoeplinger,
steveisok and
vitek-karas
matouskozak
reviewed
Jan 19, 2025
ivanpovazan
force-pushed
the
helloandroid
branch
from
8f3a933 to
60bb3da
Compare
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-extra-platforms |
|
Pull request contains merge conflicts. |
This reverts commit 156cc0e.
…ops and forces UseMonoRuntime=false
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ivanpovazan
changed the title
matouskozak
approved these changes
Jan 29, 2025
Member
matouskozak
left a comment
matouskozak
left a comment
There was a problem hiding this comment.
Good job! I left a few comments on stuff that I wasn't sure about.
src/tests/FunctionalTests/Android/Device_Emulator/LibraryMode_AOT_LLVM/Program.cs
Show resolved
Hide resolved
Member
Author
|
CI failures are unrelated. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
AndroidBuild.targetsin AndroidSampleApp.AndroidBuild.targetsto opt-in for building the sample and functional tests with CoreCLRCoreCLR support verification
Functional test
Verified on osx-arm64 host that the following build/run commands run a functional test on CoreCLR:
HelloAndroid
Fixes: #110811
Contributes to: #111745