[release/9.0-staging] Backport test fixes related to BinaryFormatter removal#111508
Merged
jkotas merged 2 commits intodotnet:release/9.0-stagingfrom Jan 17, 2025
Merged
[release/9.0-staging] Backport test fixes related to BinaryFormatter removal#111508jkotas merged 2 commits intodotnet:release/9.0-stagingfrom
jkotas merged 2 commits intodotnet:release/9.0-stagingfrom
Conversation
* don't run Drawing-related tests that do things like creating Bitmaps on Mono, as it's not supported (it does not support ComWrappers) * re-enable the tests
adamsitnik
added
test-enhancement
ghost
added
the
needs-area-label
jkotas
approved these changes
Jan 16, 2025
adamsitnik
added
area-System.Formats.Nrbf
and removed
needs-area-label
Member
|
Test fixes - tell mode. |
This was referenced Jan 17, 2025
Open
Member
|
Thank you @adamsitnik for the backport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #110550 and #111208 to release/9.0-staging
Customer Impact
CI only changes.
Regression
Testing
Both fixes have been tested in the main branch.
Risk
Very low: for #110550 we just perform fewer test cases for large inputs, for #111208 we simply don't test Drawing-related types for Mono as it's not supported.