Refactor geometric type converters for improved parsing #111349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the parsing logic for string representations of geometric types (Point, Rectangle, Size, SizeF) by using `Span<Range>` to enhance performance and reduce memory allocations. Exception handling has been improved with more specific error messages for parsing failures. Additionally, tests have been updated to reflect changes in expected values and formats, covering a wider range of cases, including edge cases and whitespace handling. The syntax for array initialization has been modernized to use collection initializers for better readability. Overall, these changes enhance the robustness, readability, and performance of the type conversion code.
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
src/libraries/System.ComponentModel.TypeConverter/src/System/Drawing/SizeConverter.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.ComponentModel.TypeConverter/src/System/Drawing/SizeFConverter.cs
Outdated
Show resolved
Hide resolved
This commit refactors the `CanConvertTo` method in the `PointConverter`, `RectangleConverter`, `SizeConverter`, and `SizeFConverter` classes. The changes enhance readability and maintainability by replacing the use of an array to hold converted values with direct string interpolation for constructing the return value. This results in clearer and more concise code.
karakasa
reviewed
Jan 13, 2025
| ConstructorInfo? ctor = typeof(Rectangle).GetConstructor(new Type[] { | ||
| typeof(int), typeof(int), typeof(int), typeof(int)}); | ||
| ConstructorInfo? ctor = typeof(Rectangle).GetConstructor( | ||
| [typeof(int), typeof(int), typeof(int), typeof(int)]); |
Contributor
There was a problem hiding this comment.
Can these param lists be static readonly arrays?
Contributor
Author
There was a problem hiding this comment.
Can I once ask for ConstructorInfo and remember it or should I not do that?
Contributor
Author
There was a problem hiding this comment.
I thought that creating the InstanceDescriptor class is a rare operation and we shouldn't consume memory to speed it up.
This was referenced Jan 13, 2025
Open
Refactor the `ConvertFrom` method in `PointConverter`, `RectangleConverter`, `SizeConverter`, and `SizeFConverter` to use `AsSpan().Trim()` for improved performance by reducing string allocations.
3 tasks
Member
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ericstj
approved these changes
Mar 18, 2025
Member
ericstj
left a comment
ericstj
left a comment
There was a problem hiding this comment.
Changes LGTM, thank you for the improvement
Member
|
/ba-g failures are networking test flakiness |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #92424
This commit refactors the parsing logic for string representations of geometric types (Point, Rectangle, Size, SizeF) by using
Span<Range>to enhance performance and reduce memory allocations.Exception handling has been improved with more specific error messages for parsing failures.
Additionally, tests have been updated to reflect changes in expected values and formats, covering a wider range of cases, including edge cases and whitespace handling.
The syntax for array initialization has been modernized to use collection initializers for better readability.
Overall, these changes enhance the robustness, readability, and performance of the type conversion code.