Use alternative format string specifier to ensure decimal point is present#111254
Merged
jkoritzinsky merged 1 commit intodotnet:mainfrom Jan 15, 2025
Merged
Use alternative format string specifier to ensure decimal point is present#111254jkoritzinsky merged 1 commit intodotnet:mainfrom
jkoritzinsky merged 1 commit intodotnet:mainfrom
Conversation
3 tasks
jkotas
approved these changes
Jan 15, 2025
Member
jkotas
left a comment
There was a problem hiding this comment.
LGTM.
The insignificant zeros do not look great, but I assume that we do not care enough to strip them.
Member
Author
|
Yeah I think given the small number of ildasm users, it's fine. We can clean it up in the a future PR. |
Member
Author
|
/backport to release/9.0-staging |
Contributor
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/12780296814 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this change, ildasm will generate the following:
Fixes #111014