Define Pack target in dotnet-pgo-pack.proj #111193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Member
Author
|
@jkoritzinsky any idea why this dotnet-pgo-pack.proj project exists at all? It just invokes pack on the dotnet-pgo.csproj. |
akoeplinger
approved these changes
Jan 8, 2025
Member
|
According to #48724 it looks like just because we weren't invoking Pack before? |
Member
Author
|
Thanks for the link. I removed the |
Member
Author
|
/ba-g fast merge to unblock dependency flow. The remaining still running legs are test execution only which aren't impacted by this change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks dotnet/sdk#45709