Skip to content

[S390x] Fix endian bug in minipal #110985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkoritzinsky merged 1 commit into from
Dec 30, 2024
Merged

[S390x] Fix endian bug in minipal #110985

jkoritzinsky merged 1 commit into from
Dec 30, 2024

Conversation

@saitama951
Copy link
Contributor

@saitama951 saitama951 commented Dec 29, 2024 •
edited
Loading

after #107889 is merged we see test cases crashing on s390x

Starting program: /home/sanjam/test-build-script/build-scripts-s390x/runtime/runtime/.dotnet/dotnet --info
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
[New Thread 0x3fff63008c0 (LWP 1186966)]
[New Thread 0x3fff45008c0 (LWP 1186967)]
[New Thread 0x3fff42008c0 (LWP 1186968)]
Process terminated.
Enocnueter dniifinetr ceruisnow ihell ooikgnu  perosruec' iMssniMgnafiseRtseuocr_eoNeNtuarAlms 'niS syet.mrPvita.eoCeriL.bV refi yht enitslaalitnoo  fN.TEi  socpmeleta dnd eo son tender peiairgn ,na dhttat ehs ateto  fht erpcose sah son tebocemc rourpted.

Thread 1 "dotnet" received signal SIGABRT, Aborted.
__pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
44            return INTERNAL_SYSCALL_ERROR_P (ret) ? INTERNAL_SYSCALL_ERRNO (ret) : 0;

This is primarily because the "BIGENDIAN" macro is defined in src/native/minipal/minipalconfig.h.in which generates a minipalconfig.h which needs to be included in utf8.c in order for the macro to be used there.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 29, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Dec 29, 2024
@saitama951
Copy link
Contributor Author

saitama951 commented Dec 29, 2024

cc: @jkoritzinsky

@saitama951
Copy link
Contributor Author

saitama951 commented Dec 30, 2024

can this be merged?

@jkoritzinsky jkoritzinsky merged commit 1613dd3 into dotnet:main Dec 30, 2024
154 of 156 checks passed
@saitama951 saitama951 mentioned this pull request Jan 2, 2025
Merged
iii-i pushed a commit to IBM/dotnet-s390x that referenced this pull request Jan 2, 2025
@saitama951 @iii-i
add dependency and backport commits
00a5ab6 
backport fixes
dotnet/runtime#110985
dotnet/runtime#107559

add mandatory dependency in DockerFile
dotnet/runtime#109681
dotnet/arcade#15233

Signed-off-by: Sanjam Panda <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees

No one assigned

Labels

community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saitama951 @jkoritzinsky