JIT: generalize empty try/catch to also handle empty try/fault #110464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically the same transformation we just started doing for try/catch also works for try/fault, so just broaden the set of cases, and rename a few things.
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
@amanasifkhalid PTAL I was going to handle this by enhancing the try-finally case, but realized that try-catch removal already does the right things. Looks like there are a modest number of diffs. |
Member
Author
|
The repro case from the above is now IN0004: 000000 push rbp
IN0005: 000001 sub rsp, 32
IN0006: 000005 lea rbp, [rsp+0x20]
G_M9330_IG02: ; offs=0x00000A, size=0x000C, bbWeight=1, PerfScore 3.50, gcrefRegs=0000 {}, byrefRegs=0000 {}, BB01 [0000], byref
IN0001: 00000A mov ecx, 56
IN0002: 00000F call [System.Console:WriteLine(int)]
IN0003: 000015 nop
G_M9330_IG03: ; offs=0x000016, size=0x0006, bbWeight=1, PerfScore 1.75, epilog, nogc, extend
IN0007: 000016 add rsp, 32
IN0008: 00001A pop rbp
IN0009: 00001B ret You will note we don't tail call... we currently must identify tail call candidates fairly early, before we've removed the EH, so we miss this one. Seems like we ought to be able to fix that too, but will leave that for a future PR. |
jakobbotsch
approved these changes
Dec 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the same transformation we just started doing for try/catch also works for try/fault, so just broaden the set of cases, and rename a few things.