Update System.Speech to also recognize Speech_OneCore#110123
Update System.Speech to also recognize Speech_OneCore#110123stephentoub merged 2 commits intodotnet:mainfrom
Conversation
ghost
added
the
| @@ -21,7 +21,12 @@ protected ObjectTokenCategory(string keyId, RegistryDataKey key) | |||
| internal static ObjectTokenCategory Create(string sCategoryId) | |||
| { | |||
| RegistryDataKey key = RegistryDataKey.Open(sCategoryId, true); | |||
There was a problem hiding this comment.
I assume this doesn't throw if the key isn't there -- it ends up calling into the COM interface so I guess that's the case
danmoseley
left a comment
danmoseley
left a comment
There was a problem hiding this comment.
It wasn't discussed - I haven't heard of this. See no problem with it, but wouldn't this apply to .NET Framework as well? (Perhaps a similar change was already made there by someone?)
If we were still adding features there, sure. |
|
Without context, I don't know whether it's adding features, or simply ensuring the scenario continues to work fully. Anyway, separate to this. |
|
does this fix #108991 |
Possibly. It depends which voices they mean. This won't help with the "natural voices". |
|
@stephentoub ok to merge? |
2 participants
Closes #110120
@danmoseley, I believe you ported System.Speech over to core. Are you aware of reasons to not do this? Is there someone we should ask?