Add Span<byte> overloads for ProtectedData #109529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProtectedData only has allocating byte[] overloads, but in .NET 5+, Span<byte> overloads can avoid allocations.
|
Note regarding the |
ghost
added
|
Note regarding the |
bartonjs
reviewed
Nov 5, 2024
...em.Security.Cryptography.ProtectedData/ref/System.Security.Cryptography.ProtectedData.csproj
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Nov 5, 2024
...System.Security.Cryptography.ProtectedData/src/System/Security/Cryptography/ProtectedData.cs
Show resolved
Hide resolved
vcsjones
reviewed
Nov 5, 2024
src/libraries/System.Security.Cryptography.ProtectedData/tests/ArrayProtectedDataTests.cs
Outdated
Show resolved
Hide resolved
...System.Security.Cryptography.ProtectedData/src/System/Security/Cryptography/ProtectedData.cs
Show resolved
Hide resolved
vcsjones
reviewed
Nov 5, 2024
src/libraries/System.Security.Cryptography.ProtectedData/tests/SpanProtectedDataTests.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Nov 5, 2024
...System.Security.Cryptography.ProtectedData/src/System/Security/Cryptography/ProtectedData.cs
Outdated
Show resolved
Hide resolved
...System.Security.Cryptography.ProtectedData/src/System/Security/Cryptography/ProtectedData.cs
Show resolved
Hide resolved
...System.Security.Cryptography.ProtectedData/src/System/Security/Cryptography/ProtectedData.cs
Outdated
Show resolved
Hide resolved
...System.Security.Cryptography.ProtectedData/src/System/Security/Cryptography/ProtectedData.cs
Outdated
Show resolved
Hide resolved
...System.Security.Cryptography.ProtectedData/src/System/Security/Cryptography/ProtectedData.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.ProtectedData/tests/ArrayProtectedDataTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.ProtectedData/tests/SpanProtectedDataTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.ProtectedData/tests/SpanProtectedDataTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.ProtectedData/tests/SpanProtectedDataTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.ProtectedData/tests/SpanProtectedDataTests.cs
Outdated
Show resolved
Hide resolved
Wrong issue link 🙂 |
…ystem/Security/Cryptography/ProtectedData.cs Co-authored-by: Jeremy Barton <[email protected]>
…ystem/Security/Cryptography/ProtectedData.cs Co-authored-by: Jeremy Barton <[email protected]>
…ystem/Security/Cryptography/ProtectedData.cs Co-authored-by: Jeremy Barton <[email protected]>
…ystem/Security/Cryptography/ProtectedData.cs Co-authored-by: Jeremy Barton <[email protected]>
…/SpanProtectedDataTests.cs Co-authored-by: Jeremy Barton <[email protected]>
…ystem/Security/Cryptography/ProtectedData.cs Co-authored-by: Jeremy Barton <[email protected]>
…ystem/Security/Cryptography/ProtectedData.cs Co-authored-by: Jeremy Barton <[email protected]>
…ystem/Security/Cryptography/ProtectedData.cs Co-authored-by: Jeremy Barton <[email protected]>
bartonjs
reviewed
Nov 5, 2024
...System.Security.Cryptography.ProtectedData/src/System/Security/Cryptography/ProtectedData.cs
Outdated
Show resolved
Hide resolved
...System.Security.Cryptography.ProtectedData/src/System/Security/Cryptography/ProtectedData.cs
Outdated
Show resolved
Hide resolved
...System.Security.Cryptography.ProtectedData/src/System/Security/Cryptography/ProtectedData.cs
Outdated
Show resolved
Hide resolved
vcsjones
reviewed
Nov 5, 2024
...System.Security.Cryptography.ProtectedData/src/System/Security/Cryptography/ProtectedData.cs
Show resolved
Hide resolved
...System.Security.Cryptography.ProtectedData/src/System/Security/Cryptography/ProtectedData.cs
Outdated
Show resolved
Hide resolved
This was referenced Nov 8, 2024
bartonjs
approved these changes
Nov 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProtectedData only has allocating byte[] overloads, but in .NET 5+, Span overloads can avoid allocations.
Resolves #108734