System.DirectoryServices.Protocols: Force using LDAP V3 for SASL binding #109450
Conversation
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
0xced
force-pushed
the
System.DirectoryServices.Protocols-LDAPV3
branch
from
a9c3e8d to
45c354d
Compare
0xced
force-pushed
the
System.DirectoryServices.Protocols-LDAPV3
branch
from
45c354d to
35100d4
Compare
0xced
changed the title
| try | ||
| { | ||
| // Bump up the protocol version because ldap_sasl_interactive_bind requires LDAP V3 else it returns LDAP_NOT_SUPPORTED and this ends up throwing LdapException: The feature is not supported. | ||
| SessionOptions.ProtocolVersion = 3; |
There was a problem hiding this comment.
For non-OSX, this must be working before the change above -- will this break V1\V2 users in those cases?
There was a problem hiding this comment.
Actually I don't have a Linux machine to test. I tried to setup Kerberos + OpenLDAP in Docker to test on Linux but I couldn't create a working environment.
|
Note: I used https://github.com/0xced/dotnet-ldap-experiment to test this fix since building the .NET runtime repository and working on it in Rider on macOS is always a challenge! |
steveharter
left a comment
steveharter
left a comment
There was a problem hiding this comment.
My understanding is that ProtocolVersion 3 came out years ago (1997?) and is backwards compatible with v2, so little risk based on that.
|
/azp run runtime-dev-innerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 participants
Fixes #109449