Skip to content

Implement IUtf8SpanParsable on System.Version #109252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephentoub merged 6 commits into from
Nov 8, 2024
Merged

Implement IUtf8SpanParsable on System.Version #109252

stephentoub merged 6 commits into from
Nov 8, 2024

Conversation

@lilinus
Copy link
Contributor

@lilinus lilinus commented Oct 26, 2024

Contributes to #81500

@ghost ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Oct 26, 2024
@ghost
Copy link

ghost commented Oct 26, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Oct 26, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 26, 2024
@build-analysis build-analysis bot mentioned this pull request Oct 26, 2024
Closed
3 tasks
tannergooding
tannergooding reviewed Oct 28, 2024
View reviewed changes
stephentoub
stephentoub approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks.

@stephentoub stephentoub merged commit a1b81e1 into dotnet:main Nov 8, 2024
146 checks passed
This was referenced Nov 12, 2024
Closed
Closed
Closed
Closed
@DrewScoggins DrewScoggins mentioned this pull request Nov 14, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergooding tannergooding tannergooding left review comments

@stephentoub stephentoub stephentoub approved these changes

Assignees

No one assigned

Labels

community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lilinus @stephentoub @tannergooding