Update ThunkGenerator to handle multi-nested classes #109210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
Member
Author
|
I can't set the area label, but I believe @davidwrighton owns this? I have two other PRs held up by this change because they add unrecognized nested intrinsic classes. |
Member
Cc @tannergooding @dotnet/jit-contrib |
tannergooding
approved these changes
Oct 29, 2024
Member
|
This needs a secondary review and for the conflict to be resolved before it can be merged. |
am11
reviewed
Oct 29, 2024
src/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetGenerator.cs
Show resolved
Hide resolved
Member
|
CC @dotnet/jit-contrib for secondary sign-off. The changes here are relatively straightforward and mostly impact the tooling that generates the various |
Member
|
CC @dotnet/jit-contrib for secondary sign-off. |
BruceForstall
approved these changes
Nov 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the generated code for R2R intrinsic class name to ISA mapping, fixing a mis-mapping for
Avx10v1.V512and setting it up to support the new approved APIs with nestedV256andV512classes.After fixing the logic, I noticed the generator started creating mappings for the double-nested
_VL_X64ISAs, which it turns out don't actually exist on the managed side. So I've removed those from the instruction set file and all references to them from JIT.