Skip to content

[cdac] Implement ISOSDacInterface::GetModule and IXCLRDataModule::GetFileName #109133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elinor-fung merged 15 commits into from
Oct 24, 2024
Merged

[cdac] Implement ISOSDacInterface::GetModule and IXCLRDataModule::GetFileName #109133

elinor-fung merged 15 commits into from
Oct 24, 2024

Conversation

@elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Oct 22, 2024

  • Add ClrDataModule to cDAC as its implementation of IXCLRDataModule and IXCLRDataModule2
    • Delegates to legacy implementation for everything except for GetFileName
    • Implements ICustomQueryInterface to handle QI-ing the legacy DAC for IMetaDataImport
  • Implement ISOSDacInterface::GetModule
    • Gets a module from the legacy DAC and passes it to the cDAC ClrDataModule
  • Cache the module file name on Module
    • Update comments around how it is expected to be set
  • Add GetFileName to Loader contract
  • Implement IXClrDataModule::GetFileName

Contributes to #99302, #108553

cc @AaronRobinsonMSFT @davidwrighton

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Oct 22, 2024

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

This was referenced Oct 23, 2024
Closed
Closed
Closed
This was referenced Oct 23, 2024
Closed
Open
lambdageek
lambdageek reviewed Oct 23, 2024
View reviewed changes
lambdageek
lambdageek reviewed Oct 23, 2024
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Oct 24, 2024
Open
3 tasks
@build-analysis build-analysis bot mentioned this pull request Oct 24, 2024
Open
3 tasks
@elinor-fung elinor-fung merged commit d450d9c into dotnet:main Oct 24, 2024
149 of 151 checks passed
@elinor-fung elinor-fung deleted the cdac-xclrmodule-filename branch October 24, 2024 20:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageek lambdageek lambdageek approved these changes

@max-charlamb max-charlamb Awaiting requested review from max-charlamb

Assignees

@elinor-fung elinor-fung

Labels

area-Diagnostics-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elinor-fung @lambdageek