Revert "Put brotli on the FetchContent plan" #109108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a7fc1ea.
steveisok
requested review from
MichalStrehovsky and
marek-safar
as code owners
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
Member
Author
|
Kicked off an official build. If it fails the same, will close this PR. |
Member
Author
|
The nativeaot legs pass on the official build, so I'm going to merge this to unblock. |
Member
Author
|
/ba-g Unblocks the official build. |
akoeplinger
approved these changes
Oct 22, 2024
This was referenced Oct 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this might have broken the nativeaot legs on the official build. All nativeaot legs error out with an arch variant of:
bin/native/net10.0-linux-Release-arm/libbrotlicommon.a' is not added because the package already contains file 'runtimes/linux-arm/native/libbrotlicommon.aReverts #107166