Skip to content

[release/8.0] Remove *.pp file#108998

Closed
carlossanlop wants to merge 2 commits intodotnet:release/8.0from
carlossanlop:RemovePP
Closed

[release/8.0] Remove *.pp file#108998
carlossanlop wants to merge 2 commits intodotnet:release/8.0from
carlossanlop:RemovePP

Conversation

@carlossanlop
Copy link
Contributor

Tell-mode.

I accidentally merged this file when turning off the OOB packages in the codeflow.

I'm surprised we don't ignore these files in .gitignore so I included the entry in that file.

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@ericstj
Copy link
Member

ericstj commented Oct 21, 2024

Checking if it's OK to merge this, or if it will reset servicing builds.

@ericstj ericstj added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 21, 2024
@ericstj
Copy link
Member

ericstj commented Oct 21, 2024

I confirmed, we should wait for now. Merge this after we're done with the current month's servicing. Removing the approved label for now to avoid any accident.

@carlossanlop
Copy link
Contributor Author

Closing in favor of #109290, t that one's targeting staging.

@carlossanlop carlossanlop deleted the RemovePP branch October 29, 2024 16:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-libraries NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants