-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Simplify bool.TryFormat #108575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Simplify bool.TryFormat #108575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@EgorBot -intel -arm64 -profiler using System.Runtime.CompilerServices;
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args);
public class Benchmarks
{
static bool[] _values = Enumerable.Range(0, 256).Select(i => i % 2 == 0).ToArray();
static char[] _output = new char[4096];
[Benchmark]
public void WriteBools()
{
Span<char> output = _output;
foreach (var value in _values)
{
if (value.TryFormat(output, out int written))
output = output.Slice(written);
else
throw new InvalidOperationException();
}
Consume(output);
}
[MethodImpl(MethodImplOptions.NoInlining)]
void Consume(Span<char> _){}
} |
Member
Author
|
To be fair, I expected this PR to slightly regress performance since we currently generate a bit suboptimal codegen for |
Member
Author
|
@EgorBot -intel -arm64 -profiler using System.Runtime.CompilerServices;
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args);
public class Benchmarks
{
static bool[] _values = Enumerable.Range(0, 256).Select(i => i % 2 == 0).ToArray();
static char[] _output = new char[4096];
[Benchmark]
public void WriteBools()
{
Span<char> output = _output;
foreach (var value in _values)
{
if (value.TryFormat(output, out int written))
output = output.Slice(written);
else
throw new InvalidOperationException();
}
Consume(output);
}
[MethodImpl(MethodImplOptions.NoInlining)]
void Consume(Span<char> _){}
} |
This was referenced Oct 5, 2024
Member
Author
|
@EgorBot -mono -intel -arm64 using System.Runtime.CompilerServices;
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args);
public class Benchmarks
{
static bool[] _values = Enumerable.Range(0, 256).Select(i => i % 2 == 0).ToArray();
static char[] _output = new char[4096];
[Benchmark]
public void WriteBools()
{
Span<char> output = _output;
foreach (var value in _values)
{
if (value.TryFormat(output, out int written))
output = output.Slice(written);
else
throw new InvalidOperationException();
}
Consume(output);
}
[MethodImpl(MethodImplOptions.NoInlining)]
void Consume(Span<char> _){}
} |
Contributor
Member
Author
|
@EgorBot -mono -intel -arm64 --envvars MONO_ENV_OPTIONS:--interpreter using System.Runtime.CompilerServices;
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args);
public class Benchmarks
{
static bool[] _values = Enumerable.Range(0, 256).Select(i => i % 2 == 0).ToArray();
static char[] _output = new char[4096];
[Benchmark]
public void WriteBools()
{
Span<char> output = _output;
foreach (var value in _values)
{
if (value.TryFormat(output, out int written))
output = output.Slice(written);
else
throw new InvalidOperationException();
}
Consume(output);
}
[MethodImpl(MethodImplOptions.NoInlining)]
void Consume(Span<char> _){}
} |
xtqqczze
added a commit
to xtqqczze/dotnet-runtime
that referenced
this pull request
Oct 6, 2024
xtqqczze
added a commit
to xtqqczze/dotnet-runtime
that referenced
this pull request
Oct 6, 2024
xtqqczze
added a commit
to xtqqczze/dotnet-runtime
that referenced
this pull request
Oct 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a perf test