[release/8.0-staging] Fix IndexOf Optimization Code#108563
Merged
ericstj merged 4 commits intorelease/8.0-stagingfrom Oct 7, 2024
Merged
[release/8.0-staging] Fix IndexOf Optimization Code#108563ericstj merged 4 commits intorelease/8.0-stagingfrom
ericstj merged 4 commits intorelease/8.0-stagingfrom
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
tarekgh
added
Servicing-approved
Member
|
This is approved by email. |
MihaZupan
approved these changes
Oct 7, 2024
ericstj
approved these changes
Oct 7, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #108499 to release/8.0-staging
/cc @tarekgh
Customer Impact
Users can run into inconsistent results when calling
String.IndexOf(...)which can cause some failure in apps. The issue #108424 describes the problem. This is reported and escalated byTeams CMD OPEXteam. We have provided some workaround, but it is not perfect as it may cause some side effects depending on the scenario the workaround is used with.Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Manually tested all failure cases, added more tests to cover the failing cases, and passed all regression tests.
Risk
Low, we have added extra condition to check for the failing case before
IndexOfoperation return negative result. No other logic has changed.