Switch SwiftSelf<T> position requirement to last#108547
Switch SwiftSelf<T> position requirement to last#108547jakobbotsch merged 2 commits intodotnet:mainfrom
SwiftSelf<T> position requirement to last#108547Conversation
This is added as the last parameter by the Swift compiler, so to support instance calls taking parameters this needs to come last.
ghost
added
the
|
@jkurdek @kotlarmilos any idea on the Mono crash? |
|
I tried reproing the mono failure locally. Both on arm64 and x64. The tests passed without problems. There might be something less obvious going on. I will take another look next week. |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| } | ||
|
|
||
| [Fact] | ||
| public unsafe static void TestSelfIsFrozenNonEnregisteredStructWithExtraArgs() |
There was a problem hiding this comment.
It seems that this is the test which fails on the CI. So far I have determined that the error also occurs when we use non-generic SwifSelf instead. The error seems to be only occurring on the runtime x64 macos runtime_tests pipeline.
There was a problem hiding this comment.
I opened #108855 about this and disabled this test against that issue
jakobbotsch
changed the title
SwiftSelf<T> position requirement to lastSwiftSelf<T> position requirement to last
jkurdek
left a comment
jkurdek
left a comment
There was a problem hiding this comment.
LGTM! Thanks for opening mono tracking issue!
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/11332643117 |
|
/ba-g The chrome-DebuggerTests failures look like #108078, but were "dead lettered" so build analysis is not picking it up |
4 participants
This is added as the last parameter by the Swift compiler, so to support instance calls taking parameters this needs to come last.
Fix #107946