Remove HelperMethodFrames (HMF) from Reflection code paths #108415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @mangod9 |
This was referenced Oct 1, 2024
jkotas
reviewed
Oct 1, 2024
jkotas
reviewed
Oct 1, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
I added a few more APIs that were straight forward to convert. |
jkotas
reviewed
Oct 2, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 2, 2024
RuntimeType.IsInstanceOfType for CoreCLR and Mono.
jkotas
reviewed
Oct 2, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 2, 2024
src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
Outdated
Show resolved
Hide resolved
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Oct 3, 2024
…8415) Convert RuntimeTypeHandle.AllocateComObject() to QCall. Convert RuntimeFieldHandle.GetValue() to QCall. Remove FCThrow from RuntimeFieldHandle.GetToken(). Convert RuntimeFieldHandle.SetValue() to QCall. Convert RuntimeTypeHandle.IsInstanceOfType() to fast/slow paths. Convert RuntimeHelpers.PrepareDelegate() to QCall. Convert ReflectionInvocation.InvokeDispMethod() to QCall. Convert RuntimeType.get_GUID to QCall.
lambdageek
pushed a commit
to lambdageek/runtime
that referenced
this pull request
Oct 3, 2024
…8415) Convert RuntimeTypeHandle.AllocateComObject() to QCall. Convert RuntimeFieldHandle.GetValue() to QCall. Remove FCThrow from RuntimeFieldHandle.GetToken(). Convert RuntimeFieldHandle.SetValue() to QCall. Convert RuntimeTypeHandle.IsInstanceOfType() to fast/slow paths. Convert RuntimeHelpers.PrepareDelegate() to QCall. Convert ReflectionInvocation.InvokeDispMethod() to QCall. Convert RuntimeType.get_GUID to QCall.
This was referenced Oct 8, 2024
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
RuntimeTypeHandle.AllocateComObject()to QCall.Convert
RuntimeFieldHandle.GetValue()to QCall.Remove
FCThrowfromRuntimeFieldHandle.GetToken().Convert
RuntimeFieldHandle.SetValue()to QCall.Convert
RuntimeTypeHandle.IsInstanceOfType()to fast/slow paths.Convert
RuntimeHelpers.PrepareDelegate()to QCall.Convert
ReflectionInvocation.InvokeDispMethod()to QCall.Convert
RuntimeType.get_GUIDto QCall.