[release/9.0]: ARM64-SVE: Allow SVE ops to re-use the same registers #107818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ARM64-SVE: Allow SVE ops to re-use the same registers * Add Sve.IsSupported * restore an assert * better asserts
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
kunalspathak
added
the
Servicing-consider
jeffschwMSFT
approved these changes
Sep 13, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. please get a code review. when ready this can be merged
jeffschwMSFT
added
Servicing-approved
amanasifkhalid
approved these changes
Sep 13, 2024
Contributor
Author
|
@jeffschwMSFT - this is ready to merge. |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107084 to release/9.0
Customer Impact
This bug was found internally where we had few conservative asserts that are not possible to have. Removed them and added some test coverage. This doesn't impact Release code but is there for completion. Also, contains minor changes from #106693.
Regression
This is not a regression, but merely a newly discovered bug from our internal testing.
Testing
Added test cases that uncovered the problem and ran all the existing SVE tests under stress.
Risk
Low. This only affects certain SVE instructions code paths. Besides, SVE is an experimental feature for .NET 9.