[NRBF] Remove array allocation when decoding decimals.
#107797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By directly passing a collection expression to `decimal`'s constructor, we avoid allocating an array on frameworks that have an overload that accepts a `ReadOnlySpan<int>`, in which case the span's memory is allocated on the stack.
ghost
added
the
needs-area-label
teo-tsirpanis
added
area-System.Formats.Nrbf
and removed
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
stephentoub
approved these changes
Sep 13, 2024
3 tasks
adamsitnik
approved these changes
Sep 20, 2024
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you @teo-tsirpanis !
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
By directly passing a collection expression to `decimal`'s constructor, we avoid allocating an array on frameworks that have an overload that accepts a `ReadOnlySpan<int>`, in which case the span's memory is allocated on the stack.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By directly passing a collection expression to
decimal's constructor, we avoid allocating an array on frameworks that have an overload that accepts aReadOnlySpan<int>, in which case the span's memory is allocated on the stack.