Skip to content

Added JsonMarshal.GetRawUtf8PropertyName API and corresponding JsonProperty tests. #107784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eiriktsarpalis merged 7 commits into from
Sep 19, 2024
Merged

Added JsonMarshal.GetRawUtf8PropertyName API and corresponding JsonProperty tests. #107784

eiriktsarpalis merged 7 commits into from
Sep 19, 2024

Conversation

@mwadams
Copy link
Contributor

@mwadams mwadams commented Sep 13, 2024

This illustrates an approach to implementing the API proposal in #107782

@ghost
Copy link

ghost commented Sep 13, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Sep 13, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 13, 2024
@mwadams mwadams mentioned this pull request Sep 13, 2024
Closed
@mwadams mwadams changed the title Added JsonMarshal API and corresponding JsonProperty tests. Added JsonMarshal.GetRawUtf8PropertyName API and corresponding JsonProperty tests. Sep 13, 2024
@mwadams mwadams marked this pull request as ready for review September 18, 2024 15:27
@terrajobst terrajobst linked an issue Sep 19, 2024 that may be closed by this pull request
[API Proposal]: Add JsonMarshal.GetRawUtf8PropertyName API #107782
Closed
eiriktsarpalis
eiriktsarpalis approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eiriktsarpalis eiriktsarpalis merged commit 681643c into dotnet:main Sep 19, 2024
@AndyAyersMS AndyAyersMS mentioned this pull request Sep 24, 2024
Closed
sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
@mwadams @sirntar
Added JsonMarshal.GetRawUtf8PropertyName API and corresponding JsonPr…
c26c860 
…operty tests. (dotnet#107784)

* Added JsonMarshal API and corresponding JsonProperty tests.

* Updated documentation to better reflect what is being returned.

* Improved documentation.

* Revert changes to System.Text.Json.sln
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees

No one assigned

Labels

area-System.Text.Json community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add JsonMarshal.GetRawUtf8PropertyName API

2 participants

@mwadams @eiriktsarpalis