Fix SuperPMI collections#107588
Merged
BruceForstall merged 4 commits intodotnet:mainfrom Sep 10, 2024
Merged
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to this area: @hoyosjs |
Contributor
Author
|
/azp run runtime-coreclr superpmi-collection-test |
|
No pipelines are associated with this pull request. |
1. Remove FSharp benchmark dll from realworld collection, since it no longer has any benchmarks. 2. Properly pass `-cross` switch when building CORE_ROOT. Propagate `crossBuild` more widely through the scripts.
Contributor
Author
|
Fixes #107522 |
BruceForstall
force-pushed
the
FixSpmiCollectCreateCoreRootPublic
branch
from
eaa99ae to
8b5bca6
Compare
Contributor
Author
|
@dotnet/jit-contrib @kunalspathak PTAL |
Contributor
kunalspathak
left a comment
kunalspathak
left a comment
There was a problem hiding this comment.
added some questions/comments.
| - name: crossArg | ||
| value: '-cross' | ||
|
|
||
| - ${{ each variable in parameters.variables }}: |
Contributor
There was a problem hiding this comment.
Is this needed so it can get the crossArg variable value?
Contributor
Author
There was a problem hiding this comment.
Basically, we need to inherit all the passed in variables as well as set crossArg. This is one way to do that.
This was referenced Sep 10, 2024
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
* Fix SuperPMI collections 1. Remove FSharp benchmark dll from realworld collection, since it no longer has any benchmarks. 2. Properly pass `-cross` switch when building CORE_ROOT. Propagate `crossBuild` more widely through the scripts. * Pass `container` to xplat-job in run-superpmi-collect-job * Better error message * More `container` changes
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
* Fix SuperPMI collections 1. Remove FSharp benchmark dll from realworld collection, since it no longer has any benchmarks. 2. Properly pass `-cross` switch when building CORE_ROOT. Propagate `crossBuild` more widely through the scripts. * Pass `container` to xplat-job in run-superpmi-collect-job * Better error message * More `container` changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-crossswitch when building CORE_ROOT. PropagatecrossBuildmore widely through the scripts.