Allow preinitializing spans created from arrays #107575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
|
Thank you! |
jkotas
reviewed
Sep 10, 2024
jkotas
approved these changes
Sep 10, 2024
agocke
approved these changes
Sep 10, 2024
Member
agocke
left a comment
agocke
left a comment
There was a problem hiding this comment.
A few suggestions on how you could use patterns to remove some repeated conditionals.
Feel free to ignore this feedback. Sometimes I find this useful, sometimes it reads worse. It's a judgement call.
|
|
||
| instance = new ReadOnlySpanValue(readOnlySpanElementType, bytes, byteOffset, byteLength); | ||
| } | ||
| else if (readOnlySpanElementType != null && ctorSig.Length == 1 && ctorSig[0].IsArray |
Member
There was a problem hiding this comment.
Suggested change
| else if (readOnlySpanElementType != null && ctorSig.Length == 1 && ctorSig[0].IsArray | |
| else if (readOnlySpanElementType != null && ctorSig is [ { IsArray: true }] |
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/TypePreinit.cs
Outdated
Show resolved
Hide resolved
Member
|
Not a regression but could it be a 9.0 candidate? |
Member
Author
We have a formal list of things that are allowed into 9.0 at this point and the only perf fixes that would meet 9.0 bar are "Significant performance regression from last release" (not just regression, it would also need to be significant to even consider a backport). |
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107541.
Cc @dotnet/ilc-contrib