Skip to content

Add AltJit entries in DOTNETVariables list of testenvironment.proj #107475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kunalspathak wants to merge 2 commits into from
Closed

Add AltJit entries in DOTNETVariables list of testenvironment.proj #107475

kunalspathak wants to merge 2 commits into from

Conversation

@kunalspathak
Copy link
Contributor

@kunalspathak kunalspathak commented Sep 6, 2024

Seems the entries are needed to set those environment variables during test execution.

@kunalspathak kunalspathak added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 6, 2024
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 6, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Sep 6, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

BruceForstall
BruceForstall reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't include the lsraarm64.cpp (whitespace) change here

@BruceForstall
Copy link
Contributor

BruceForstall commented Sep 6, 2024

Please don't include the lsraarm64.cpp (whitespace) change here

oh, I guess you did that just to cause the pipeline to get triggered

@kunalspathak
Copy link
Contributor Author

kunalspathak commented Sep 6, 2024

Please don't include the lsraarm64.cpp (whitespace) change here

oh, I guess you did that just to cause the pipeline to get triggered

That's right

@kunalspathak
Copy link
Contributor Author

kunalspathak commented Sep 9, 2024

There are couple of failures that we run into when turning on AltJit.

  • Assertion failed 'info.compLocalsCount == info.compPatchpointInfo->NumberOfLocals()' in 'X:G():S:this' during 'Pre-import
  • Failed to load alternative JIT compiler (not sure why that would happen)

@kunalspathak kunalspathak mentioned this pull request Dec 2, 2024
Merged
@kunalspathak
Copy link
Contributor Author

kunalspathak commented Jan 9, 2025

no longer needed, now that we have Cobalt 100 machines in CI

@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@BruceForstall BruceForstall BruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kunalspathak kunalspathak

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kunalspathak @BruceForstall